[U-Boot-Users] [PATCH] ppc4xx: Fix compilation warnings and coding style issues in HCU4/HCU5

[Niklaus Giger]

 Hi Stefan 
 
Thanks for fixing the compile warnings. I fixed my compilation script to
look for warnings in order to fix these kind of problems before submitting
to the u-boot list.

[..] 
> diff --git a/board/netstal/hcu4/Makefile b/board/netstal/hcu4/Makefile 
> index c0d719f..b13d9d4 100644 
> --- a/board/netstal/hcu4/Makefile 
> +++ b/board/netstal/hcu4/Makefile 
> @@ -27,11 +27,11 @@ vpath hcu_flash.c ../common 
>  vpath nm_bsp.c ../common 
>   
>  # NOBJS : Netstal common objects 
> -NOBJS        = fixed_sdram.o hcu_flash.o nm_bsp.o 
> +NOBJS        = ../common/fixed_sdram.o ../common/hcu_flash.o \ 
> ../common/nm_bsp.o 
>  COBJS        = $(BOARD).o 
>  SOBJS        = 
>   
> -SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) ../common/$(NOBJS:.o=.c) 
> +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) $(NOBJS:.o=.c) 
>  OBJS := $(addprefix $(obj),$(COBJS)) 
>  NOBJS        := $(addprefix $(obj),$(NOBJS)) 
>  SOBJS        := $(addprefix $(obj),$(SOBJS)) 

I think that your fixes for the Makefiles are wrong, as they do not work when
one wants to compile out-of-tree. E.g if I specify O=../build, then I get 
errors like 
FATAL: can't create /home/ng/u-boot/build/board/netstal/hcu5/../common/hcu_flash.o: No such file or directory 
 
Is it okay if I submit a patch to revert the changes or do you suggest 
another way how to fix the Makefiles? 
 
Best regards 
 
Niklaus Giger