[U-Boot-Users] Release status - things to be done

[Scott Wood]

On Sun, Jul 06, 2008 at 01:05:40AM +0200, Wolfgang Denk wrote:
> * Current NAND code (the "Constants for hardware specific CLE/ALE/NCE
>   functions" in "include/linux/mtd/nand.h", lines 75ff, break building
>   on some boards like NETPHONE, NETTA, NETTA2, NETTA_ISDN, NETVIA_V2,
>   SXNI855T (which have different definitions with the same names in
>   their board config files) with error messages like these:
> 
> 	In file included from /home/wd/git/u-boot/work/include/nand.h:29,
> 			 from board.c:94:
> 	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:82:1: warning: "NAND_CTL_SETCLE" redefin
> 	ed
> 	In file included from /home/wd/git/u-boot/work/include/config.h:4,
> 			 from /home/wd/git/u-boot/work/include/common.h:35,
> 			 from board.c:24:
> 	/home/wd/git/u-boot/work/include/configs/NETPHONE.h:547:1: warning: this is the location o
> 	f the previous definition
> 	In file included from /home/wd/git/u-boot/work/include/nand.h:29,
> 			 from board.c:94:
> 	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:84:1: warning: "NAND_CTL_CLRCLE" redefin
> 	ed
> 	In file included from /home/wd/git/u-boot/work/include/config.h:4,
> 			 from /home/wd/git/u-boot/work/include/common.h:35,
> 			 from board.c:24:

OK, I'll look into this.

> * "include/linux/mtd/mtd.h" contains a definition of the DEBUG macro
>   which conflicts with normal use like adding '-DDEBUG' on the
>   command line.

Already fixed in the nand repo, will send a pull request when the
previous issue is fixed.

>   Also, I think we whould get rid of all the printk() stuff.

That'll cause more merge conflicts when bringing in a new version of the
upstream code.

-Scott