[U-Boot-Users] [PATCH v3] Add MVBC_P board

[Wolfgang Denk]

In message <48747E75.3060005 at matrix-vision.de> you wrote:
> 
...
> --- a/Makefile
> +++ b/Makefile
> @@ -743,6 +743,14 @@ uc101_config:		unconfig
>  motionpro_config:	unconfig
>  	@$(MKCONFIG) motionpro ppc mpc5xxx motionpro
>  
> +MVBC_P_config: unconfig 
> +	@mkdir -p $(obj)include
> +	@mkdir -p $(obj)board/mvbc_p
> +	@ >$(obj)include/config.h
> +	@[ -z "$(findstring MVBC_P,$@)" ] || \
> +	{   	echo "#define CONFIG_MVBC_P" 	>>$(obj)include/config.h; \
> +	}

Please put the '}' on the previous line. This saves a line in an ever
growing Makefile ;-)

> diff --git a/board/matrix_vision/mvbc_p/Makefile b/board/matrix_vision/mvbc_p/Makefile
> new file mode 100644
> index 0000000..7ae34cf
> --- /dev/null
> +++ b/board/matrix_vision/mvbc_p/Makefile
> @@ -0,0 +1,50 @@
...
> +distclean:	clean
> +	rm -f $(LIB) core *.bak .depend

Please change this into "$(obj).depend"

> diff --git a/board/matrix_vision/mvbc_p/config.mk b/board/matrix_vision/mvbc_p/config.mk
> new file mode 100644
> index 0000000..1c2a13e
> --- /dev/null
> +++ b/board/matrix_vision/mvbc_p/config.mk
> @@ -0,0 +1,30 @@
...
> +sinclude $(TOPDIR)/board/$(BOARDDIR)/config.tmp

Please change this into

	sinclude $(OBJTREE)/board/$(BOARDDIR)/config.tmp


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am a computer. I am dumber than any human and smarter than any  ad-
ministrator.