[U-Boot-Users] [PATCH 3/6] sbc8560: define eth0 and eth1 instead of eth1 and eth2

[Paul Gortmaker]

Ben Warren wrote:
> Paul Gortmaker wrote:
>> The existing config doesn't define CONFIG_HAS_ETH0, and so the
>> fdt support doesn't update the zeros in the dtb local-mac with
>> real data from the u-boot env.  Since the existing config is
>> tailored to just two interfaces, get rid of the ETH2 definitions
>> at the same time.
>> ---
>>  include/configs/sbc8560.h |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/configs/sbc8560.h b/include/configs/sbc8560.h
>> index f07fbc0..e5195e0 100644
>> --- a/include/configs/sbc8560.h
>> +++ b/include/configs/sbc8560.h
>> @@ -407,11 +407,10 @@
>>  
>>  /*Note: change below for your network setting!!! */
>>  #if defined(CONFIG_TSEC_ENET) || defined(CONFIG_ETHER_ON_FCC)
>> +#  define CONFIG_HAS_ETH0
>>  #  define CONFIG_ETHADDR    00:01:af:07:9b:8a
>>  #  define CONFIG_HAS_ETH1
>>  #  define CONFIG_ETH1ADDR    00:01:af:07:9b:8b
>> -#  define CONFIG_HAS_ETH2
>> -#  define CONFIG_ETH2ADDR    00:01:af:07:9b:8c
>>  #endif
>>  
>>  #define CONFIG_SERVERIP        192.168.0.131
>>   
> Please get rid of all default network parameters while you're at it 
> (MAC addresses, IP addresses etc.)

Is there a set list of which things are considered OK and
which are ones that folks would rather not see?  A quick
snoop around shows lots of other boards doing the 192.168.x.y
type stuff and default MAC addresses and similar.

I'm fine with doing a cleanup;  I just don't want to do it twice,
and I'd rather it be consistent across all the boards as well.

Thanks,
Paul.
>
> regards,
> Ben