[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

Stefan Roese sr at denx.de
Fri Jul 11 11:36:24 CEST 2008


On Friday 11 July 2008, Michal Simek wrote:
> Still is there coding style issue.
>
> and you have one extra header file which is uneeded. I recommend you
> move usefull values directly to driver.
>
> WD: I looked at include/dtt.h there are many driver specific values. IMHO
> these value should be usefull move to driver c file. What do you think
> about?

Full ACK. Patches welcome. :)

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================




More information about the U-Boot mailing list