[U-Boot-Users] [PATCH] I2C Monitor Chip ADT7460 support

Wolfgang Denk wd at denx.de
Sun Jul 13 15:21:30 CEST 2008


In message <4618.7248-495-1777888767-1215766461 at seznam.cz> you wrote:
> Still is there coding style issue.
> 
> and you have one extra header file which is uneeded. I recommend you 
> move usefull values directly to driver. 
> 
> WD: I looked at include/dtt.h there are many driver specific values. IMHO these
> value should be usefull move to driver c file. What do you think about?

Please feel free to send a patch to clean this up.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A good marriage would be between a blind wife and deaf husband.
                                               -- Michel de Montaigne




More information about the U-Boot mailing list