[U-Boot-Users] [PATCH 3/7] sbc8560: define eth0 and eth1 instead of eth1 and eth2

[Wolfgang Denk]

In message <8dee444198e3c87ef471198cbd2e25c4e1b558fb.1215803423.git.paul.gortmaker at windriver.com> you wrote:
>
> +/* You can compile in a MAC address and your custom net settings by using
> + * the * following syntax.  Your board should be marked with the assigned
----------^

Bogus '*' here?

> + * MAC addresses directly on it.
> + */
> +#if 0
> +#define CONFIG_ETHADDR		00:01:af:07:9b:8a
> +#define CONFIG_ETH1ADDR		00:01:af:07:9b:8b
>  #define CONFIG_SERVERIP		192.168.0.131
>  #define CONFIG_IPADDR		192.168.0.105
> -#define CONFIG_GATEWAYIP	0.0.0.0
> +#define CONFIG_GATEWAYIP	192.168.0.1
>  #define CONFIG_NETMASK		255.255.255.0
> +#endif
> +

I think this should be removed. There is really no good reason to add
network configuration at all to  the  board  config  file  (with  the
exception of the 2 or 3 boards which actually boot from real ROM).



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If in any problem you find yourself doing an immense amount of  work,
the answer can be obtained by simple inspection.