[U-Boot-Users] [PATCH] fsl-i2c: fix writes to data segment before relocation

Wolfgang Denk wd at denx.de
Wed Jul 30 00:10:30 CEST 2008


In message <1216668383-17967-1-git-send-email-timur at freescale.com> you wrote:
> Prevent i2c_init() in fsl_i2c.c from writing to the data segment before
> relocation.  Commit d8c82db4 added the ability for i2c_init() to program the
> I2C bus speed and save the value in i2c_bus_speed[], which is a global
> variable.  It is an error to write to the data segment before relocation,
> which is what i2c_init() does when it stores the bus speed in i2c_bus_speed[].
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
> 
> Wolfgang, please apply this directly to fix the I2C bug we've been talking about.
> 
>  drivers/i2c/fsl_i2c.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Once they go up, who cares where  they  come  down?  That's  not  my
department."                                       - Werner von Braun




More information about the U-Boot mailing list