[U-Boot-Users] [PATCH 7/7] ARM: Add support for S3C6400 based SMDK6400 board

[Wolfgang Denk]

In message <Pine.LNX.4.64.0807311247520.4832 at axis700.grange> you wrote:
> This board can only boot U-Boot from NAND-flash. This patch adds a nand_spl
> driver for it too. SMDK6400 can also boot from the NOR flash, but due to
> hardware limitations it can only address 64KiB on it, which is not enough for
> U-Boot. Ported from u-boot-1.1.6 version by Samsung.

Coding style errors: spaces instead of TAB for indentation.

> diff --git a/board/samsung/smdk6400/Makefile b/board/samsung/smdk6400/Makefile
> new file mode 100644
> index 0000000..1200e45
> --- /dev/null
> +++ b/board/samsung/smdk6400/Makefile
> @@ -0,0 +1,51 @@
> +#
> +# (C) Copyright 2000, 2001, 2002
> +# Wolfgang Denk, DENX Software Engineering, wd at denx.de.

Who contributed more to this Makefile - you or me?

This comment applies to the (C) notices in ALL files you submitted.

> +include $(TOPDIR)/config.mk
> +
> +LIB	= lib$(BOARD).a
> +
> +OBJS	:= smdk6400.o
> +#OBJS	:= smdk6400.o flash.o
> +SOBJS	:= lowlevel_init.o
> +
> +$(LIB):	$(OBJS) $(SOBJS)
> +	$(AR) crv $@ $(SOBJS) $(OBJS)
> +
> +clean:
> +	rm -f $(SOBJS) $(OBJS)
> +
> +distclean:	clean
> +	rm -f $(LIB) core *.bak .depend

All this is broken, as it does not support out-of-tree building.

> diff --git a/board/samsung/smdk6400/lowlevel_init.S b/board/samsung/smdk6400/lowlevel_init.S
> new file mode 100644
> index 0000000..9371415
> --- /dev/null
> +++ b/board/samsung/smdk6400/lowlevel_init.S
...
> +/* This looks like wakeup support. Don't know if it's going to be used, untested. */

Line length.

> +#if 1

Please remove the "#if 1" here and everywhere else.

> +        ldr     r0, =(ELFIN_CLOCK_POWER_BASE + RST_STAT_OFFSET)
> +        ldr     r1, [r0]
> +        bic     r1, r1, #0xfffffff7
> +        cmp     r1, #0x8
> +        beq     wakeup_reset
> +#endif
> +
> +1:
> +	mov	lr, r12
> +	mov	pc, lr
> +
> +#if 1
> +wakeup_reset:
> +
> +	/*Clear wakeup status register*/
> +	ldr	r0, =(ELFIN_CLOCK_POWER_BASE+WAKEUP_STAT_OFFSET)
> +	ldr	r1, [r0]
> +	str	r1, [r0]
> +
> +        /*LED test*/
> +        ldr     r0, =ELFIN_GPIO_BASE
> +        ldr     r1, =0x3000
> +        str     r1, [r0, #GPNDAT_OFFSET]
> +
> +	/*Load return address and jump to kernel*/
> +	ldr	r0, =(ELFIN_CLOCK_POWER_BASE + INF_REG0_OFFSET)
> +	ldr	r1, [r0]	/* r1 = physical address of s3c6400_cpu_resume function*/

Line length.

Please also check all the other lines and files.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real programmers can write assembly code in any language.   :-)
                      - Larry Wall in  <8571 at jpl-devvax.JPL.NASA.GOV>