[U-Boot-Users] [PATCH/review] Blackfin: use on-chip syscontrol() to reset

[Mike Frysinger]

On Sunday 01 June 2008, Wolfgang Denk wrote:
> In message <1212298724-15152-10-git-send-email-vapier at gentoo.org> you wrote:
> > When available, use the on-chip syscontrol() rom function to perform a
> > system reset rather than our own local method.
> ...
> > -		asm("jump (%0);" : : "a" (bfin_reset));
> > +		if (0 /*BOOTROM_CAPS_SYSCONTROL -- current silicon is broken*/)
> > +			syscontrol(SYSCTRL_SOFTRESET, NULL, NULL);
> > +		else
> > +			asm("jump (%0);" : : "a" (bfin_reset));
> >  }
>
> Your comment suggests you change something, but actually you;re just
> adding dead code.

it's dead code because the current silicon is broken.  i know the code works 
as ive tested it in scenarios where the anomaly isnt triggered, it just cant 
be enabled until fixed hardware is released.  it's much easier to go back and 
fix 1 if statement then have to carry this patch somewhere it can got lost 
and i need to waste time and rewrite it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080601/b2250a82/attachment.pgp