[U-Boot-Users] [PATCH/review] Blackfin: use on-chip syscontrol() to reset

[Wolfgang Denk]

In message <1212298724-15152-10-git-send-email-vapier at gentoo.org> you wrote:
> When available, use the on-chip syscontrol() rom function to perform a
> system reset rather than our own local method.
...
> -		asm("jump (%0);" : : "a" (bfin_reset));
> +		if (0 /*BOOTROM_CAPS_SYSCONTROL -- current silicon is broken*/)
> +			syscontrol(SYSCTRL_SOFTRESET, NULL, NULL);
> +		else
> +			asm("jump (%0);" : : "a" (bfin_reset));
>  }

Your comment suggests you change something, but actually you;re just
adding dead code.

Rejected.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Extreme feminine beauty is always disturbing.
	-- Spock, "The Cloud Minders", stardate 5818.4