[U-Boot-Users] [PATCH 1/2] Add support for mpc8313 based BUBBATWO

[Detlev Zundel]

Hi Tor,

> These patches add support for the mpc8313 based BUBBATWO board.
>
> Signed-off-by: Tor Krill <tor at excito.com>
> ---
>  MAINTAINERS                |    4 +
>  MAKEALL                    |    1 +
>  Makefile                   |    3 +
>  include/configs/BUBBATWO.h |  516 ++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 524 insertions(+), 0 deletions(-)
>  create mode 100644 include/configs/BUBBATWO.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ac7572c..c188728 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -224,6 +224,10 @@ Sangmoon Kim <dogoil at etinsys.com>
>  	debris			MPC8245
>  	KVME080			MPC8245
>  
> +Tor Krill <tor at excito.com>
> +
> +	BUBBATWO		MPC8313
> +
>  Thomas Lange <thomas at corelatus.se>
>  
>  	GTH			MPC860
> diff --git a/MAKEALL b/MAKEALL
> index 0674069..da28c7a 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -332,6 +332,7 @@ LIST_83xx="		\
>  	MPC837XERDB	\
>  	sbc8349		\
>  	TQM834x		\
> +	BUBBATWO	\
>  "

Did you notice any unsorted list in MAKEALL?  See?

> diff --git a/Makefile b/Makefile
> index 3401203..93f563f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1993,6 +1993,9 @@ MPC8313ERDB_66_config: unconfig
>  	fi ;
>  	@$(MKCONFIG) -a MPC8313ERDB ppc mpc83xx mpc8313erdb freescale
>  
> +BUBBATWO_config: unconfig
> +	@$(MKCONFIG) BUBBATWO ppc mpc83xx bubbatwo excito
> +
>  MPC8315ERDB_config: unconfig
>  	@$(MKCONFIG) -a MPC8315ERDB ppc mpc83xx mpc8315erdb freescale

Although not every section is sorted, I'd vote also to use sorting here,
simply to make such a large file more transparent.

> diff --git a/include/configs/BUBBATWO.h b/include/configs/BUBBATWO.h
> new file mode 100644
> index 0000000..4e27c6f
> --- /dev/null
> +++ b/include/configs/BUBBATWO.h
> @@ -0,0 +1,516 @@
> +/*
> + * Copyright (C) Freescale Semiconductor, Inc. 2006.
> + * Copyright (C) Excito Elektronik i Skåne, 2008.
> + *

[...]

> +
> +#define CONFIG_ETHADDR		00:22:02:00:95:01
> +#define CONFIG_HAS_ETH1
> +#define CONFIG_HAS_ETH0
> +#define CONFIG_ETH1ADDR		00:22:02:00:95:02

Having MAC-Addresses in U-Boot proper is considered to be a bug.  See
the long list of mails on this topic...

Cheers
  Detlev

-- 
Referee's report: This paper contains much that is new and much that
is true. Unfortunately, that which is true is not new and that which
is new is not true.
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de