[U-Boot-Users] [patch 0/6] DM9000: Several fixes/cleanups for the DM9000A controller

[Remy Bohmer]

Hello Stefano,

> Great ! It works, I tested now with bigger files and it sounds good !

Good news!

> I have seen that the complete patch (all patch 0-xx) is not so big and
> smaller as the limit of the mailing list (17k < 40k). What about to send
> only the complete patch ? It is easier to read for the review.

I made it seperate patches because all changes are seperate from each other.
One does not have to install the complete series. Every step should
result in a bootable and working driver.
Some other rule says: Keep patches as small as possible...

I looked at the complete change at first, but that makes it
unreadable, and I believe, harder to review.
Many changes are trivial, only some are more intrusive...

> There are some issues with the coding style, too (trailing blanks, for
> example).

hmm, I have configured quilt such that it normally removes those whitespaces...
I have to find out what went wrong here.

Wolfgang, Is the merge window for these patches still open?
If so, I will clean up the patches, and distribute it again in about an hour.

Kind Regards,

Remy

2008/6/4 Stefano Babic <sbabic at denx.de>:
> Remy Bohmer wrote:
>
>> I will post a mail in a few minutes solving this...
>> Please apply this new past on top of the 6-patches series I posted yesterday.
>
>
> I have seen that the complete patch (all patch 0-xx) is not so big and
> smaller as the limit of the mailing list (17k < 40k). What about to send
> only the complete patch ? It is easier to read for the review.
>
> There are some issues with the coding style, too (trailing blanks, for
> example).
>
> Kind regards,
> Stefano
>
> --
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
>