[U-Boot-Users] [Patch 0/9] U-boot-V2: Introduce I2C support for SDP3430

[Sascha Hauer]

On Wed, Jun 18, 2008 at 10:15:58AM -0500, Menon, Nishanth wrote:
> Timur,
> > -----Original Message-----
> > From: Timur Tabi [mailto:timur at freescale.com]
> > Sent: Wednesday, June 18, 2008 9:55 AM
> > To: Menon, Nishanth
> > Cc: Sascha Hauer; Laurent Desnogues; Kamat, Nishant; philip.balister at gmail.com; u-boot-
> > users at lists.sourceforge.net
> > Subject: Re: [U-Boot-Users] [Patch 0/9] U-boot-V2: Introduce I2C support for SDP3430
> >
> > Do we really want to bloat U-Boot with these huge Linux drivers?  U-Boot already
> > has I2C support that works pretty well.  Your patchset is overkill, IMHO.
> Please see U-boot v2 here: http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-v2.git;a=tree;f=drivers;h=2b524fc7692e5ee0b99843df17a911dd54c84e73;hb=78c2fde77a953351aac8d7e92336eb37b64c0985
> 
> It does not have i2c support. And IMHO, using kernel like i2c addition in U-Boot v2 is appropriate. Why this is not a bloat U-Boot v2?
> A) Now, if you just want i2c_transfer without any device interface, you don't need to compile in the CHARDEV.
> B) Since we use a different linking strategy in U-Boot-v2 which uses gcc link stage to decide which functions be retained and which not, it is pretty neat to see all unused functionality disappear.

Note that this is only true when modules are disabled. Once modules are
enabled, every function marked with EXPORT_MODULE gets linked in as you
don't know which functions will be needed later. So please check your
build with modules enabled.

Sascha


-- 
Pengutronix e.K. - Linux Solutions for Science and Industry
-----------------------------------------------------------
Kontakt-Informationen finden Sie im Header dieser Mail oder
auf der Webseite -> http://www.pengutronix.de/impressum/ <-