[U-Boot-Users] [PATCH 2/3] 83xx: serdes setup routines

[Jean-Christophe PLAGNIOL-VILLARD]

On 18:07 Fri 07 Mar     , Anton Vorontsov wrote:
> This patch adds few routines to configure serdes on 837x targets.
> 
> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
> ---
>  cpu/mpc83xx/Makefile |    2 +-
>  cpu/mpc83xx/serdes.c |  161 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/fsl_serdes.h |   25 ++++++++
>  3 files changed, 187 insertions(+), 1 deletions(-)
>  create mode 100644 cpu/mpc83xx/serdes.c
>  create mode 100644 include/fsl_serdes.h
> 
> diff --git a/cpu/mpc83xx/Makefile b/cpu/mpc83xx/Makefile
> index 94a3cb8..678be29 100644
> --- a/cpu/mpc83xx/Makefile
> +++ b/cpu/mpc83xx/Makefile
> @@ -29,7 +29,7 @@ LIB	= $(obj)lib$(CPU).a
>  
>  START	= start.o
>  COBJS	= traps.o cpu.o cpu_init.o speed.o interrupts.o \
> -	  spd_sdram.o ecc.o qe_io.o pci.o fdt.o
> +	  spd_sdram.o ecc.o qe_io.o pci.o fdt.o serdes.o
Please split it with on line for one file
>  
>  SRCS	:= $(START:.o=.S) $(SOBJS:.o=.S) $(COBJS:.o=.c)
>  OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
> diff --git a/cpu/mpc83xx/serdes.c b/cpu/mpc83xx/serdes.c
> new file mode 100644
> index 0000000..666bffd
> --- /dev/null
> +++ b/cpu/mpc83xx/serdes.c
> @@ -0,0 +1,161 @@
> +/*
> + * Freescale SerDes initialization routine
> + *
> + * Copyright (C) 2007 Freescale Semicondutor, Inc. All rights reserved.
> + * Copyright (C) 2008 MontaVista Software, Inc. All rights reserved.
> + *
> + * Author: Li Yang <leoli at freescale.com>
> + *
> + * This program is free software; you can redistribute  it and/or modify it
> + * under  the terms of  the GNU General  Public License as published by the
> + * Free Software Foundation;  either version 2 of the  License, or (at your
> + * option) any later version.
> + */
> +
> +#include <config.h>
> +
> +#ifdef CONFIG_FSL_SERDES
Please move it to the Makefile
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <fsl_serdes.h>
> +
Best Regards,
J.