[U-Boot-Users] [PATCH v1 2/5] ATA: Add the libata support

Dave Liu r63238 at freescale.com
Wed Mar 19 10:08:59 CET 2008


On Wed, 2008-03-19 at 09:35 +0000, Tor Krill wrote:

> After some further work with these pathces. (I currently work on a
> SIL3114 driver using them)
> 
> It seems like there is a "lot" of code duplication in libata.h and the
> existant ata.h. Thus making it impossible to include both ones. Which i
> would like to do.

Yes, it is my one concern.

My another concern is, the common dir originally have one cmd_sata.c.
However, the cmd_sata.c is not generic.

Wolfgang,
How do we handle it?

> Pasted below is the modifications i did to do to get it working.
> 
> Could one perhaps merge the differences? Or is there other suggestions on
> how to solve this?

So, Wolfgang,
Can we merge the new stuff from libata.h to ata.h?

Thanks,
Dave







More information about the U-Boot mailing list