[U-Boot-Users] [PATCH v1 2/5] ATA: Add the libata support

Wolfgang Denk wd at denx.de
Wed Mar 19 13:14:12 CET 2008


Dear Dave,

in message <1205917739.3654.81.camel at localhost.localdomain> you wrote:
>
> > It seems like there is a "lot" of code duplication in libata.h and the
> > existant ata.h. Thus making it impossible to include both ones. Which i
> > would like to do.
> 
> Yes, it is my one concern.

As usual: patches welcome. They should apply, of course.

> My another concern is, the common dir originally have one cmd_sata.c.
> However, the cmd_sata.c is not generic.

In which way not generic?

How about submitting patches?

> How do we handle it?

Submit patches?

> Can we merge the new stuff from libata.h to ata.h?

There is no libata.h in the U-Boot tree so you cannot merge code from
there.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Gewöhnlich glaubt der Mensch,  wenn er nur Worte hört,  es müsse sich
dabei doch auch was denken lassen.                 -- Goethe, Faust I




More information about the U-Boot mailing list