[U-Boot-Users] [PATCH v1 2/5] ATA: Add the libata support

Wolfgang Denk wd at denx.de
Wed Mar 19 13:06:42 CET 2008


In message <PWN74WD6.1205919334.9849270.tor at localhost> you wrote:
> 
> After some further work with these pathces. (I currently work on a
> SIL3114 driver using them)
> 
> It seems like there is a "lot" of code duplication in libata.h and the
> existant ata.h. Thus making it impossible to include both ones. Which i
> would like to do.

There is no such file like libata.h in mainline U-Boot code. What are
you referring to?

> Pasted below is the modifications i did to do to get it working.

Modifications against which source version exactly?

> Could one perhaps merge the differences? Or is there other suggestions on
> how to solve this?

Please make sure to add your SIgned-off-by line when submitting
patcehs.

Also, it would be better to split changes of content and pure
"beautifying" changes into separate patches.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
An Ada exception is when a routine gets in trouble and says
'Beam me up, Scotty'.




More information about the U-Boot mailing list