[U-Boot-Users] [PATCH v1 2/5] ATA: Add the libata support

[Tor Krill]

On 3/19/2008, "Wolfgang Denk" <wd at denx.de> wrote:

>In message <PWN74WD6.1205919334.9849270.tor at localhost> you wrote:
>>
>> After some further work with these pathces. (I currently work on a
>> SIL3114 driver using them)
>>
>> It seems like there is a "lot" of code duplication in libata.h and the
>> existant ata.h. Thus making it impossible to include both ones. Which i
>> would like to do.
>
>There is no such file like libata.h in mainline U-Boot code. What are
>you referring to?

Sorry if this was not clear. This reply was on the patch for addition of
libata.h and thus i referred to that patch.

>> Pasted below is the modifications i did to do to get it working.
>
>Modifications against which source version exactly?

The original patch and mainline ata.h

>> Could one perhaps merge the differences? Or is there other suggestions on
>> how to solve this?
>
>Please make sure to add your SIgned-off-by line when submitting
>patcehs.

Sure, will do. This version was merely for comments.

>Also, it would be better to split changes of content and pure
>"beautifying" changes into separate patches.

Once again. Ok. will do.

I can resubmit the additions to ata.h, and then maybe Dave could remove
the corresponding parts from his patch?

Best Regards,

/Tor