[U-Boot-Users] [PATCH] ColdFire: Fix FEC transmit issue for MCF5275

[Jon Loeliger]

Tsi-Chung Liew wrote:

> +	/*
> +	 * FEC fix for MCF5275, FEC unable to initial transmit data packet.
> +	 * A nop will ensure the descriptor polling active completed.
> +	 */
> +#ifdef CONFIG_M5275
> +	__asm__ ("nop");
> +#endif
> +
>  #ifdef CFG_UNIFY_CACHE
>  	icache_invalid();
>  #endif

At the risk of being very picky, I think this should be
written to have the comment inside the #ifdef so that
the code and comment are not accidentally separated.

#if defined(CONFIG_M5275)
	/*
	 * FEC ...
	 */
	__asm__("nop");
#endif

But, that may be just me.  Take it or leave it. :-)

jdl