[U-Boot-Users] [PATCH] ColdFire: Fix FEC transmit issue for MCF5275

[Scott Wood]

On Wed, Mar 19, 2008 at 09:05:27AM -0500, Jon Loeliger wrote:
> Tsi-Chung Liew wrote:
> 
> > +	/*
> > +	 * FEC fix for MCF5275, FEC unable to initial transmit data packet.
> > +	 * A nop will ensure the descriptor polling active completed.
> > +	 */
> > +#ifdef CONFIG_M5275
> > +	__asm__ ("nop");
> > +#endif
> > +
> >  #ifdef CFG_UNIFY_CACHE
> >  	icache_invalid();
> >  #endif
> 
> At the risk of being very picky, I think this should be
> written to have the comment inside the #ifdef so that
> the code and comment are not accidentally separated.

At the risk of being somewhat less picky, I think there should be more
explanation of why a nop solves anything in a robust manner.

-Scott