[U-Boot-Users] [PATCH 2/2] Freescale eLBC FCM NAND driver

[Stefan Roese]

On Tuesday 25 March 2008, Scott Wood wrote:
> >> +static void fsl_elbc_select_chip(struct mtd_info *mtd, int chip)
> >> +{
> >> +	/* The hardware does not seem to support multiple
> >> +	 * chips per bank.
> >> +	 */
> >
> > please use this comment style
>
> Do we really need such trivial style differences with the Linux driver,
> which will only serve as an annoyance when keeping the two in sync, not
> to mention wasting vertical space with no readability benefit because
> there's pretty much always a (mostly) blank line above the comment?

This preferred comment style *should* be used. But I would not object to your 
(and others) multi-line comment style either. It's being used in Linux 
frequently and as you already mentioned saves one line. Especially when 
moving Linux drivers to U-Boot, we should allow this coding style for better 
maintenance.

Just my 2 cents.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================