[U-Boot-Users] [PATCH V2 0/9] SATA framework and FSL SATA support patch set

[Liu Dave]

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Wed 3/26/2008 7:58 AM
To: Liu Dave
Cc: u-boot-external; Phillips Kim
Subject: Re: [PATCH V2 0/9] SATA framework and FSL SATA support patch set
 
Dear Dave,

in message <1206008182.3739.6.camel at localhost.localdomain> you wrote:
> 
> The patch set include two parts:
> 1. SATA framework support
> 2. The Freescale SATA controller support
...
> Dave Liu (8):
>       ATA: Add the support for SATA framework

Why add new support? We already have some...

[dave] really, I didn't find any SATA framework support in u-boot.
if you are saying the cmd_sata.c. I don't agree it.


>  board/freescale/mpc837xemds/mpc837xemds.c |    3 +
>  common/Makefile                           |    1 +
>  common/cmd_sata2.c                        |  206 +++++++

Can you please explain why we  need  a  new  file  common/cmd_sata2.c
which   duplicates  a  lot  of  functions  of  the  already  existing
common/cmd_sata.c ?

[dave]the common/cmd_sata.c is more likely controller specificed driver, not
sata framework. the cmd_sata2.c is more generic. can connect to different SATA
controller driver.
 

I think this needs to be cleaned  up.  I  will  not  accept  multiple
similar but conflicting implementations of the very same functions.

[dave]after the cmd_sata2.c is merge, I plan to move the cmd_sata.c to drivers/block.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080326/fb2b4fdb/attachment.htm