[U-Boot-Users] [PATCH V2 0/9] SATA framework and FSL SATA support patch set

[Liu Dave]

Your message is extremely difficult to read. Can you please use proper
quoting? Please read http://www.netmeister.org/news/learn2quote.html
if you need help...

[dave] sorry for that, I'm using the webmail to access my mailbox.
the webmail is stupid.


> [dave]the common/cmd_sata.c is more likely controller specificed driver, not
> sata framework. the cmd_sata2.c is more generic. can connect to different SATA
> controller driver.

Maybe. But still both the existing common/cmd_sata.c and your new
cmd_sata2.c implement the very same functions (like do_sata()) with
more or less the same sub-commands etc.

[dave] I think the same part is focusing on command line.

> I think this needs to be cleaned  up.  I  will  not  accept  multiple
> similar but conflicting implementations of the very same functions.
> 
> [dave]after the cmd_sata2.c is merge, I plan to move the cmd_sata.c to drivers/block.

Sorry, but this will not work. I will not add such  duplicated  code.
Please  add  command  level stuff to the (existing) common/cmd_sata.c
file and do not add any  new  cmd_sata2.c  which  duplicates  it.  If
necessary, clean up the code while you're there.

[dave] if I choose current command/cmd_sata.c, and don't move the drivers part of
cmd_sata.c to drivers/block. I think it will add extra-space for my image.
so, the best choice is move the drivers part of cmd_sata.c to drivers/block.
what do you think about it?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080326/8743a5e6/attachment.htm