[U-Boot-Users] [U-Boot Users][PATCH] ADS5121 IO Pin Configuration

[Wolfgang Denk]

In message <200805031715483.SM04088 at cw4mb41> you wrote:
> Adds configurable IO Pin initialization for ADS5121 and consolidates
> existing IO pin initialization.
> 
> Signed-off-by: Martha J Marx <mmarx at si...>
> ---
>  board/ads5121/ads5121.c   |   10 +--
>  cpu/mpc512x/Makefile      |    2 +-
>  cpu/mpc512x/fec.c         |   15 ----
>  cpu/mpc512x/iopin.c       |   72 ++++++++++++++++
>  cpu/mpc512x/iopin.h       |  200
> +++++++++++++++++++++++++++++++++++++++++++++
^^^^^^^^^^^^^^^^^^^^^^^

Patch again corrupted due to line wrapping.

> +	/* initialize function mux & slew rate IO inter alia on IO Pins
> */
^^^^^^^^^^^^^^^^^^^^^
Lines wrapped.

> +	iopin_initialize();
>  
> -	/* change the slew rate on all pata pins to max */
> -	reg = (unsigned long *) &(im->io_ctrl.regs[PATA_CE1_IDX]);
> -	for (i = 0; i < 9; i++)
> -		reg[i] |= 0x00000003;
>  	return 0;
>  }
>  #ifdef CONFIG_MISC_INIT_R
> diff --git a/cpu/mpc512x/Makefile b/cpu/mpc512x/Makefile
> index 2be35b2..8ba8ae8 100644
> --- a/cpu/mpc512x/Makefile
> +++ b/cpu/mpc512x/Makefile
> @@ -25,7 +25,7 @@ include $(TOPDIR)/config.mk
>  LIB	= $(obj)lib$(CPU).a
>  
>  START	= start.o
> -COBJS	= traps.o cpu.o cpu_init.o speed.o interrupts.o serial.o fec.o i2c.o
> +COBJS	= traps.o cpu.o cpu_init.o speed.o interrupts.o serial.o fec.o i2c.o
> iopin.o
^^^^^^^^^^^^^^^^^^^^^
Lines wrapped.

Also, please keep lisys sorted, and mind the maximum line length.

> diff --git a/cpu/mpc512x/iopin.c b/cpu/mpc512x/iopin.c
> new file mode 100644
> index 0000000..e2b536b
> --- /dev/null
> +++ b/cpu/mpc512x/iopin.c
> @@ -0,0 +1,72 @@
> +/*
> + * mpc512x I/O pin/pad initialization
> + */
> +#include <common.h>
> +#include <linux/types.h>
> +#include "iopin.h"

Copyright and license note missing.

> +/*
> + * IO PAD TYPES for all types fmux is used to select the funtion and ds
> sets the slew rate
^^^^^^^^^^^^^^^^^^^^^
Lines wrapped (many more lines following).

+ } ioregs_init[] = {
+#ifdef CONFIG_ADS5121
+/* FUNC1=FEC_RX_DV Sets Next 3 to FEC pads 	*/
+	{IOCTL_SPDIF_TXCLK, 	3,  0, 1, 0, 0, 0, 0, 3},
+/* Set highest Slew on 9 PATA pins		*/
+	{IOCTL_PATA_CE1, 	9,  1, 0, 0, 0, 0, 0, 3},
+/* FUNC1=FEC_COL Sets Next 15 to FEC pads 	*/
+	{IOCTL_PSC0_0, 		15, 0, 1, 0, 0, 0, 0, 3},
+/* FUNC1=SPDIF_TXCLK				*/
+	{IOCTL_LPC_CS1, 	1,  0, 1, 0, 0, 0, 1, 3},
+/* FUNC2=SPDIF_TX and sets Next pin to SPDIF_RX	*/
+	{IOCTL_I2C1_SCL, 	2,  0, 2, 0, 0, 0, 1, 3},
+/* FUNC2=DIU CLK				*/
+	{IOCTL_PSC6_0, 		1,  0, 2, 0, 0, 0, 1, 3},
+/* FUNC2=DIU_HSYNC 				*/
+	{IOCTL_PSC6_1, 		1,  0, 2, 0, 0, 0, 0, 3},
+/* FUNC2=DIUVSYNC Sets Next 26 to DIU Pads	*/
+	{IOCTL_PSC6_4, 		26, 0, 2, 0, 0, 0, 0, 3}
+#endif

No. Please avoid such board specific #ifdef'ed initializers in common
code. Please move this board specific data into board specific files.

> diff --git a/cpu/mpc512x/iopin.h b/cpu/mpc512x/iopin.h
> new file mode 100644
> index 0000000..5ef107d
> --- /dev/null
> +++ b/cpu/mpc512x/iopin.h
> @@ -0,0 +1,200 @@
> +/*
> + * mpc512x I/O pin/pad initialization
> + */

Copyright and license note missing.

> diff --git a/include/configs/ads5121.h b/include/configs/ads5121.h
> index 5f82855..04b2a96 100644
> --- a/include/configs/ads5121.h
> +++ b/include/configs/ads5121.h
> @@ -27,6 +27,7 @@
>  #ifndef __CONFIG_H
>  #define __CONFIG_H
>  
> +#define CONFIG_ADS5121 1

When moving the board specific date out of the common file above, this
#define will probably not be needed then, either.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The reasonable man adapts himself to the world; the unreasonable  one
persists  in  trying  to  adapt  the  world to himself. Therefore all
progress depends on the unreasonable man."      - George Bernard Shaw