[U-Boot-Users] [PATCH 12/17] ti_pci1410a: Fix multiple warnings and errors

[Wolfgang Denk]

In message <1211130599-28289-13-git-send-email-plagnioj at jcrosoft.com> you wrote:
> ti_pci1410a.c: In function 'voltage_set':
> ti_pci1410a.c:421: error: label at end of compound statement
> ti_pci1410a.c:435: error: label at end of compound statement
> cc1: warnings being treated as errors
> ti_pci1410a.c: At top level:
> ti_pci1410a.c:609: warning: pointer targets in initialization differ in signedness
> ti_pci1410a.c: In function 'identify':
> ti_pci1410a.c:651: warning: pointer targets in passing argument 1 of 'puts' differ in signedness
> ti_pci1410a.c:656: warning: pointer targets in passing argument 1 of 'strcmp' differ in signedness
> ti_pci1410a.c:656: warning: pointer targets in passing argument 2 of 'strcmp' differ in signedness

Please do not include long lists of error messages. It would be more
helpful if you described what you change, or why.

>  static int identify(volatile uchar *p)
>  {
> -	uchar id_str[MAX_IDENT_CHARS];
> +	char id_str[MAX_IDENT_CHARS];

This code is also already present in common/cmd_pcmcia.c; you probably
want to remove it here, too.

> --- a/include/pcmcia.h
> +++ b/include/pcmcia.h
> @@ -318,4 +318,6 @@ extern u_int *pcmcia_pgcrx[];
>  extern int check_ide_device(int slot);
>  #endif
>  
> +int pcmcia_off(void);
> +int pcmcia_on(void);
>  #endif /* _PCMCIA_H */

Then please also get rid of the lots of "extern" declarations in misc
source files which become unnecessary by that.  Thanks.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If programming was easy, they wouldn't need something as  complicated
as a human being to do it, now would they?
                       - L. Wall & R. L. Schwartz, _Programming Perl_