[U-Boot-Users] [PATCH 13/17] sc520_spunk: Fix multiple warnings

[Wolfgang Denk]

In message <1211130599-28289-14-git-send-email-plagnioj at jcrosoft.com> you wrote:
> sc520_spunk.c: In function 'pci_sc520_spunk_fixup_irq':
> sc520_spunk.c:117: warning: pointer targets in passing argument 4 of 'pci_hose_read_config_byte' differ in signedness
> sc520_spunk.c: In function 'last_stage_init':
> sc520_spunk.c:580: warning: implicit declaration of function 'ds1722_probe'
> sc520_spunk.c: In function 'spi_init_f':
> sc520_spunk.c:643: warning: implicit declaration of function 'spi_eeprom_probe'
> sc520_spunk.c:644: warning: implicit declaration of function 'mw_eeprom_probe'
> sc520_spunk.c: In function 'spi_read':
> sc520_spunk.c:660: warning: implicit declaration of function 'spi_eeprom_read'
> sc520_spunk.c:661: warning: implicit declaration of function 'mw_eeprom_read'
> sc520_spunk.c: In function 'spi_write':
> sc520_spunk.c:676: warning: implicit declaration of function 'spi_eeprom_write'
> sc520_spunk.c:677: warning: implicit declaration of function 'mw_eeprom_write'
> 
> adding mw_eeprom header

Frankly, such a commit message is useless. What is it supposed to tell
me?

> -	char tmp_pin;
> +	u8 tmp_pin;

Please use uchar if you really want an unsigned character type.

> +void spi_eeprom_probe(int x)
> +{
> +}
> +
> +int spi_eeprom_read(int x, int offset, uchar *buffer, int len)
> +{
> +	return 0;
> +}
> +
> +int spi_eeprom_write(int x, int offset, uchar *buffer, int len)
> +{
> +	return 0;
> +}

Is this supposed to be working code?

Why is this needed, then?

> --- /dev/null
> +++ b/include/mw_eeprom.h
> @@ -0,0 +1,27 @@
> +/*
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */

Copyright entry missing.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Es sind überhaupt nur die Dummköpfe, die sich den Befehlen der  Mäch-
tigen  widersetzen.  Um  sie  zu ruinieren ist es genug, ihre Befehle
treu zu erfüllen.                  - Peter Hacks: "Die schöne Helena"