[U-Boot-Users] [PATCH] mips: tolerate the MIPS 'CFG_HZ' values in the MHZ range for NAND delays

Alessandro Rubini rubini-list at gnudd.com
Mon May 19 22:44:36 CEST 2008


> +#if CFG_HZ > 100000

Shouldn't this be

	if (CFG_HZ > 100000)

instead?

It's a constant expression, and the compiler optimizes the conditional
out. Using if() instead of #if ensures that all the code is always parsed,
so the compiler can review it all and signal any problem. Not to mention
aesthetics.

/alessandro




More information about the U-Boot mailing list