[U-Boot-Users] [PATCH] mips: tolerate the MIPS 'CFG_HZ' values in the MHZ range for NAND delays

[Wolfgang Denk]

In message <20080519204436.GA3521 at mail.gnudd.com> you wrote:
> 
> > +#if CFG_HZ > 100000
> 
> Shouldn't this be
> 
> 	if (CFG_HZ > 100000)
> 
> instead?
> 
> It's a constant expression, and the compiler optimizes the conditional
> out. Using if() instead of #if ensures that all the code is always parsed,
> so the compiler can review it all and signal any problem. Not to mention
> aesthetics.

If possible, we *want* the preprocessor to remove any code that does
not apply for a specific configuration. Generating code just bloats
the memory footprint.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Houston, Tranquillity Base here.  The Eagle has landed.
                                                    -- Neil Armstrong