[U-Boot-Users] Setting processor endianess for USB modules

Wolfgang Denk wd at denx.de
Wed May 21 21:23:26 CEST 2008


In message <48348CDD.23520.310C8 at ceggers.gmx.de> you wrote:
> 
> I've made I new patch with git as requested.

Unfortunately it's unusable as your mailer wrapped long lines:

> @@ -177,10 +178,10 @@ int usb_control_msg(struct usb_device *d
>  	/* set setup command */
>  	setup_packet.requesttype = requesttype;
>  	setup_packet.request = request;
> -	setup_packet.value = swap_16(value);
> -	setup_packet.index = swap_16(index);
> -	setup_packet.length = swap_16(size);
> - 	USB_PRINTF("usb_control_msg: request: 0x%X, requesttype: 0x%X\nvalue 
> 0x%X index 0x%X length 0x%X\n",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   Here.

> +	setup_packet.value = cpu_to_le16(value);
> +	setup_packet.index = cpu_to_le16(index);
> +	setup_packet.length = cpu_to_le16(size);
> + 	USB_PRINTF("usb_control_msg: request: 0x%X, requesttype: 0x%X, value 
> 0x%X index 0x%X length 0x%X\n",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   Here.

...
> @@ -329,8 +330,7 @@ int usb_parse_config(struct usb_device *
>  				dev->config.if_desc[ifno].no_of_ep++; /* found an 
> endpoint */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   Here.

And so on. Please fix your mailer (or even better use git-send-email)


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: How do you spell "onomatopoeia"?
A: The way it sounds.




More information about the U-Boot mailing list