[U-Boot-Users] [PATCH] PPC4xx: Enable Primordial Stack for 40x and Unify ECC Handling

[Wolfgang Denk]

In message <1211397301-29656-1-git-send-email-gerickson at nuovations.com> you wrote:
> 
> * Rolls up a suite of changes to enable correct primordial stack and
>   global data handling when the data cache is used for such a purpose
>   for PPC40x-variants.

...
> --- a/board/amcc/kilauea/memory.c
> +++ b/board/amcc/kilauea/memory.c
> @@ -1,6 +1,9 @@
>  /*
> - * (C) Copyright 2007
> - * Stefan Roese, DENX Software Engineering, sr at denx.de.
> + * Copyright (c) 2008 Nuovation System Designs, LLC
> + *   Grant Erickson <gerickson at nuovations.com>
> + *
> + * Copyright (c) 2007 DENX Software Engineering, GmbH
> + *   Stefan Roese <sr at denx.de>

Please do not mess with other people's Copyright!!!!

"(C) DENX" and "(C) Stefan" are two fundamentally different things.

Never, never ever meddle with copyrights!!!

This comment applies to all files where you did this!!


> diff --git a/board/amcc/makalu/init.S b/board/amcc/makalu/init.S
> index 5e9a5e0..d74d93b 100644
> --- a/board/amcc/makalu/init.S
> +++ b/board/amcc/makalu/init.S
> @@ -1,8 +1,9 @@
>  /*
> - * (C) Copyright 2007-2008
> - * Stefan Roese, DENX Software Engineering, sr at denx.de.
> + * Copyright (c) 2008 Nuovation System Designs, LLC
> + *   Grant Erickson <gerickson at nuovations.com>
>   *
> - * Based on code provided from Senao and AMCC

Why do you delete such useful (and in terms of Copyright etc.
important) information? 

Do not do such things!!!

Feel free to add your own copyright where appropriate, but never mess
with other, already exsiting copyright information.


> + * Copyright (c) 2007-2008 DENX Software Engineering, GmbH
> + *   Stefan Roese <sr at denx.de>

Again, this is fundamentally wrong.

> diff --git a/include/configs/kilauea.h b/include/configs/kilauea.h
> index c7c42a4..953c87a 100644
> --- a/include/configs/kilauea.h
> +++ b/include/configs/kilauea.h
...
> +// #define CFG_INIT_DCACHE_CS	4

Do not use C++ comments.

...
> -#define CFG_MBYTES_SDRAM        (256)		/* 256MB			*/
> +#define CFG_MBYTES_SDRAM	256

What is your rationale for such a change?


>  /* POST support */
> -#define CONFIG_POST		(CFG_POST_MEMORY	| \
> -				 CFG_POST_CACHE		| \
> +#define CONFIG_POST		(CFG_POST_CACHE		| \
>  				 CFG_POST_CPU		| \
>  				 CFG_POST_ETHER		| \
>  				 CFG_POST_I2C		| \

STOP!!! Do not mess with the POST configurtation of the boards!

This is not mentioned anywhere in your patch description, and not
wanted either.

> diff --git a/include/configs/makalu.h b/include/configs/makalu.h
> index 67243d4..3e61925 100644
...
> -#define CONFIG_POST		(CFG_POST_MEMORY	| \
> -				 CFG_POST_CACHE		| \
> +#define CONFIG_POST		(CFG_POST_CACHE		| \

Ditto.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is dangerous to be sincere unless you are also stupid.
                                                - George Bernard Shaw