[U-Boot-Users] [PATCH] PPC4xx: Enable Primordial Stack for 40x and Unify ECC Handling

[Grant Erickson]

On 5/21/08 12:40 PM, Wolfgang Denk wrote:
> In message <1211397301-29656-1-git-send-email-gerickson at nuovations.com> you
> wrote:
>> 
>> * Rolls up a suite of changes to enable correct primordial stack and
>>   global data handling when the data cache is used for such a purpose
>>   for PPC40x-variants.
> ...
>> --- a/board/amcc/kilauea/memory.c
>> +++ b/board/amcc/kilauea/memory.c
>> @@ -1,6 +1,9 @@
>>  /*
>> - * (C) Copyright 2007
>> - * Stefan Roese, DENX Software Engineering, sr at denx.de.
>> + * Copyright (c) 2008 Nuovation System Designs, LLC
>> + *   Grant Erickson <gerickson at nuovations.com>
>> + *
>> + * Copyright (c) 2007 DENX Software Engineering, GmbH
>> + *   Stefan Roese <sr at denx.de>
> 
> Please do not mess with other people's Copyright!!!!
> 
> "(C) DENX" and "(C) Stefan" are two fundamentally different things.
> 
> Never, never ever meddle with copyrights!!!
> 
> This comment applies to all files where you did this!!

It seemed like consistent formatting without changing the nature of the
information seemed like a net improvement. Insofar as I read it, they say
the same thing, Stefan Roese as a representative of DENX. Anyway, it is not
worth debating and I can revert it easily enough.

>> diff --git a/board/amcc/makalu/init.S b/board/amcc/makalu/init.S
>> index 5e9a5e0..d74d93b 100644
>> --- a/board/amcc/makalu/init.S
>> +++ b/board/amcc/makalu/init.S
>> @@ -1,8 +1,9 @@
>>  /*
>> - * (C) Copyright 2007-2008
>> - * Stefan Roese, DENX Software Engineering, sr at denx.de.
>> + * Copyright (c) 2008 Nuovation System Designs, LLC
>> + *   Grant Erickson <gerickson at nuovations.com>
>>   *
>> - * Based on code provided from Senao and AMCC
>> + * Copyright (c) 2007-2008 DENX Software Engineering, GmbH
>> + *   Stefan Roese <sr at denx.de>
> 
> Why do you delete such useful (and in terms of Copyright etc.
> important) information?
> 
> Do not do such things!!!
> 
> Feel free to add your own copyright where appropriate, but never mess
> with other, already exsiting copyright information.

See above.

Deleted the "Senao and AMCC" like since it was no longer true/accurate.

>> diff --git a/include/configs/kilauea.h b/include/configs/kilauea.h
>> index c7c42a4..953c87a 100644
>> --- a/include/configs/kilauea.h
>> +++ b/include/configs/kilauea.h
> ...
>> +// #define CFG_INIT_DCACHE_CS 4
> 
> Do not use C++ comments.

Debugging typo. I need remove that regardless.

>> -#define CFG_MBYTES_SDRAM        (256)  /* 256MB   */
>> +#define CFG_MBYTES_SDRAM 256
> 
> What is your rationale for such a change?

The mnemonic is self explanatory and the parens add no value since 256 is a
constant.

>>  /* POST support */
>> -#define CONFIG_POST  (CFG_POST_MEMORY | \
>> -     CFG_POST_CACHE  | \
>> +#define CONFIG_POST  (CFG_POST_CACHE  | \
>> CFG_POST_CPU  | \
>> CFG_POST_ETHER  | \
>> CFG_POST_I2C  | \
> 
> STOP!!! Do not mess with the POST configurtation of the boards!
> 
> This is not mentioned anywhere in your patch description, and not
> wanted either.
>
>> diff --git a/include/configs/makalu.h b/include/configs/makalu.h
>> index 67243d4..3e61925 100644
> ...
>> -#define CONFIG_POST  (CFG_POST_MEMORY | \
>> -     CFG_POST_CACHE  | \
>> +#define CONFIG_POST  (CFG_POST_CACHE  | \
> 
> Ditto.

These ARE warranted. Specifying CFG_POST_MEMORY twice is redundant and
removing one instance thereof changes nothing, operationally. I'll add a
note to the commit/patch description.

Regards,

Grant