[U-Boot-Users] [PATCH] Additional fix to readline_into_buffer() with CONFIG_CMDLINE_EDITING before relocating

Peter Tyser ptyser at xes-inc.com
Fri May 23 01:56:52 CEST 2008


Removed unneeded command line history initialization.  Also, the original
code would access the 'initted' variable before relocation to SDRAM
which resulted in erratic behavior since the bss is not initialized when
executing from flash.

Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
---
 common/main.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/common/main.c b/common/main.c
index a17b60b..046da6f 100644
--- a/common/main.c
+++ b/common/main.c
@@ -940,12 +940,6 @@ int readline_into_buffer (const char *const prompt, char * buffer)
 	int rc;
 	static int initted = 0;
 
-	if (!initted) {
-		hist_init();
-		initted = 1;
-	}
-
-
 	/*
 	 * History uses a global array which is not
 	 * writable until after relocation to RAM.
-- 
1.5.4.3





More information about the U-Boot mailing list