[U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code

Wolfgang Denk wd at denx.de
Sun Nov 2 17:02:05 CET 2008


Dear Ilya,

In message <490BAA2A.6020806 at emcraft.com> you wrote:
> Hello Michael,
> 
> Michael Lawnick wrote:
> > I have put these patches to our board (MPC8548, NOR Flash, MTD partition
> > size 48MB).
> >
> > a) performance has improved (execution time of 'ls' reduced from ~16s to
> > ~1.5s)
> >   
> 
> Sounds good. That is what we were expecting.

If you submit a patch, then please add such comments *below* the "---"
line.

> diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
> index e7f07bf..2fc0b7d 100644
> --- a/common/cmd_jffs2.c
> +++ b/common/cmd_jffs2.c
> @@ -344,7 +344,9 @@ static int part_validate_nor(struct mtdids *id,
> struct part_info *part)
>  
>      flash = &flash_info[id->num];
>  
> -    part->sector_size = 0;
> +    /* size of last sector */
> +    part->sector_size = flash->size -
> +        (flash->start[flash->sector_count-1] - flash->start[0]);
>  
>      offset_aligned = 0;
>      for (i = 0; i < flash->sector_count; i++) {
> @@ -360,6 +362,7 @@ static int part_validate_nor(struct mtdids *id,
> struct part_info *part)
^^^^^^^^^^^^^^^^^^^^^^^^^^

Patch is correcpted because your mailer wrapped long lines.

Please fix your mailer setup and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Cleverness and Style have no place in getting a project completed.
                                                  -- Tom Christiansen


More information about the U-Boot mailing list