[U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2 code
Joakim Tjernlund
joakim.tjernlund at transmode.se
Tue Nov 4 14:14:51 CET 2008
On Tue, 2008-11-04 at 13:31 +0100, Michael Lawnick wrote:
> Michael Lawnick said the following:
> ...
> > - output of access rights is still corrupted, e.g.:
> > dÿÿÿÿ-ÿÿ-ÿ 0 Tue Oct 21 11:08:17 2008 10
> > -ÿÿÿÿ-ÿÿ-ÿ 262144 Thu Jan 01 00:00:33 1970 u-boot.bin
> > dÿÿÿÿ-ÿÿ-ÿ 0 Tue Oct 21 11:08:32 2008 1
> > dÿÿÿÿ-ÿÿ-ÿ 0 Tue Oct 21 11:00:58 2008 2
> ...
>
> Ok, fixed this in my code:
> in jffs2_1pass.c @@ mkmodestr(unsigned long mode, char *str)
> you'll find declaration
> static const char *l = "xwr";
>
> Although this is per se correct, it is not needed in context and screws
> up 'ls' in my case: Our u-boot is not placed in flash were it is located
> to on compilation time. static const char * points into flash space at
> some not properly initialized flash space. After modifying to
> char *l = "xwr";
> output of access rights is fine now:
> drwxr-xr-x 0 Tue Oct 21 11:08:17 2008 10
> -rwxr-xr-x 262144 Thu Jan 01 00:00:33 1970 u-boot.bin
> drwxr-xr-x 0 Tue Oct 21 11:08:32 2008 1
> drwxr-xr-x 0 Tue Oct 21 11:00:58 2008 2
>
> (Still directories are listed multiple times)
>
> Could we modify this declaration to my non-static version in the trunk?
Is this on PPC? If so it is due to missing fixup support. Grant Likely
once sent a patch fixing this. It got applied, but later reverted
because there was some problems that never got solved.
More information about the U-Boot
mailing list