[U-Boot] [PATCH-OMAP3] OMAP3: Plain numbers don't need parens

[Magnus Lilja]

Dear Wolfgang,

2008/11/4 Wolfgang Denk <wd at denx.de>:
> Dear Dirk,
>
> In message <49108377.0305560a.52c1.39ea at mx.google.com> you wrote:
>>
>> Use a consistent style. Plain numbers don't need parens. Proposed by Wolfgang Denk.
>>
>> Signed-off-by: Dirk Behme <dirk.behme at gmail.com>
> ...
>
> But...
>
>>  /* GPMC CS3/cs4/cs6 not avaliable */
>> -#define GPMC_BASE            (OMAP34XX_GPMC_BASE)
>> +#define GPMC_BASE            OMAP34XX_GPMC_BASE
>
> This is NOT a plain number. If I decide to use something like
>
> #define OMAP34XX_GPMC_BASE      FOO + BAR
>
> you might comment that such a #define is dangerous in itself, but why
> not protet against it? with a number we are sure we don't need parens,
> but with a macro we'd should rather play safe.

Should we really start protection against such things?


Best regards, Magnus