[U-Boot] broken lib_arm/boom.c/do_bootm_linux()

Kumar Gala galak at kernel.crashing.org
Fri Nov 7 15:01:50 CET 2008


On Nov 7, 2008, at 5:07 AM, Ilko Iliev wrote:

> Hi,
>
> There is a bug in lib_arm/boom.c/do_bootm_linux():
>    if ((flag != 0) || (flag != BOOTM_STATE_OS_GO))
>        return 1;
>
> The parameter "flag" is 0 and the above condition is always true.
>
> The result is - the boom command doesn't start the kernel.
> Affected targets: all arm based.
>
> Maybe it should be corrected to:
>    if ((flag != 0) && (flag != BOOTM_STATE_OS_GO))
>        return 1;
>

that's correct.. for some reason the lib_arm/ case didn't get fixed.   
How about sending a patch to fix it.

- k


More information about the U-Boot mailing list