[U-Boot] [PATCH 06/13 v5] ARM: OMAP3: Add memory and syslib common files

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081109140742.GC25307 at game.jcrosoft.org> you wrote:
> > --- u-boot-main.orig/examples/Makefile
> > +++ u-boot-main/examples/Makefile
> > @@ -30,10 +30,12 @@ LOAD_ADDR = 0x40000
> >  endif
> >  
> >  ifeq ($(ARCH),arm)
> > +LOAD_ADDR = 0xc100000
> >  ifeq ($(BOARD),omap2420h4)
> >  LOAD_ADDR = 0x80300000
> > -else
> > -LOAD_ADDR = 0xc100000
> > +endif
> > +ifeq ($(CPU),omap3)
> > +LOAD_ADDR = 0x80300000
> >  endif
> >  endif
> 
> Maybe we need to change it to allow arch/cpu to define itself and avoid
> ifeq/endif

In any case I think above should rather be written as

	ifeq ($(BOARD),omap2420h4)
	LOAD_ADDR = 0x80300000
	else ifeq ($(CPU),omap3)
	LOAD_ADDR = 0x80300000
	else
	LOAD_ADDR = 0xc100000
	endif

instead.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The main thing is the play itself. I swear that greed for  money  has
nothing  to  do with it, although heaven knows I am sorely in need of
money.                                           - Feodor Dostoyevsky