[U-Boot] [PATCH 12/13 v5] ARM: OMAP3: Add Overo board

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081109150511.GG25307 at game.jcrosoft.org> you wrote:
>  +

> > +	byte = 0x33;
> > +	i2c_write(0x4A, 0xEE, 1, &byte, 1);
> as beagle board please add a comment a comment to explain what you do on I2C
> > +
> > +	*((uint *) 0x49058034) = 0xFFFFFAF9;
> > +	*((uint *) 0x49056034) = 0x0F9F0FFF;
> > +	*((uint *) 0x49058094) = 0x00000506;
> > +	*((uint *) 0x49056094) = 0xF060F000;

... and what this black magic does.

And see above about using accessor fuctions / macros for register
accesses.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is much easier to suggest solutions when you know nothing