[U-Boot] [PATCH] OneNAND: Fix compiler warnings and add weak attribute to memcpy_16()

Scott Wood scottwood at freescale.com
Mon Nov 10 17:27:52 CET 2008


Stefan Roese wrote:
> On Friday 07 November 2008, Scott Wood wrote:
>> Stefan Roese wrote:
>>> This is needed for the vcth board support (still to come) which needs
>>> custom access routines here.
>> Can it just override write_bufferram and read_bufferram?
> 
> There are multiple functions here using this memcpy_16():
> 
> onenand_read_bufferram()
> onenand_sync_read_bufferram()
> onenand_write_bufferram()
> 
> So it seemed "easier" for me to just override the memcpy_16() function itself.

onenand_read_bufferram and onenand_sync_read_bufferram are alternatives 
for the read_bufferram method; you don't need to provide both.  Thus, 
it's two method overrides versus two weak overrides.  Unless the board 
code doesn't know which of the two types of read will be used?

-Scott


More information about the U-Boot mailing list