[U-Boot] [PATCH] Makefile: use find to simplify clobber and avoid some bash problem

Jerry Van Baren gerald.vanbaren at ge.com
Wed Nov 12 19:16:48 CET 2008


Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
> please try this on ubuntu
> 
> Best Regards,
> J.
>  Makefile |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 884b634..212451f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3280,9 +3280,8 @@ clobber:	clean
>  	@rm -f $(OBJS) $(obj)*.bak $(obj)ctags $(obj)etags $(obj)TAGS \
>  		$(obj)cscope.* $(obj)*.*~
>  	@rm -f $(obj)u-boot $(obj)u-boot.map $(obj)u-boot.hex $(ALL)
> -	@rm -f $(obj)tools/{crc32.c,env_embedded.c,env/crc32.c,md5.c,sha1.c,inca-swap-bytes}
> -	@rm -f $(obj)tools/{image.c,fdt.c,fdt_ro.c,fdt_rw.c,fdt_strerror.c,zlib.h}
> -	@rm -f $(obj)tools/{fdt_wip.c,libfdt_internal.h}
> +	@find $(obj)tools -name "*" -type l -print | xargs rm -f
> +	@rm -f $(obj)tools/inca-swap-bytes
>  	@rm -f $(obj)cpu/mpc824x/bedbug_603e.c
>  	@rm -f $(obj)include/asm/proc $(obj)include/asm/arch $(obj)include/asm
>  	@[ ! -d $(obj)nand_spl ] || find $(obj)nand_spl -name "*" -type l -print | xargs rm -f

Oooo, you have a risk of removing symlinks that you didn't mean to. 
Works today, what about tomorrow?

This was discussed previously, but not pushed to fruition:
<http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/48047/focus=48048>

My vote is (a) use bash specifically and keep the bashisms.

Best regards,
gvb


More information about the U-Boot mailing list