[U-Boot] [PATCH V2] cmd_bdinfo: move implementation to arch instead of common

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed Nov 12 20:45:51 CET 2008


On 14:36 Wed 12 Nov     , Mike Frysinger wrote:
> On Wed, Nov 12, 2008 at 2:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > introduce two new weak functions board_bdinfo and soc_bdinfo to allow board and
> > soc to print more information
> 
> there seems to be things that all arches print ... like memory and
> flash information.  perhaps that should be left in the common
> bdinfo().

I've prefered to let arch print this how they wish

> > +void arch_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
> > +       if(soc_bdinfo)
> > +       if(board_bdinfo)
> 
> you've got random whitespace damage all over this patch ...

I known, but I not suposed to fix PPC whitespace in the patch
I've an other one when everyone will agree on this one

Best Regards,
J.


More information about the U-Boot mailing list