[U-Boot] [PATCH 2/6] jffs2: add sector_size field to part_info structure

Ben Warren biggerbadderben at gmail.com
Thu Nov 13 19:16:22 CET 2008


Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 19:49 Thu 13 Nov     , Ilya Yanok wrote:
>   
>> This patch adds sector_size field to part_info structure (used
>> by new JFFS2 code).
>>
>> Signed-off-by: Ilya Yanok <yanok at emcraft.com>
>> ---
>>  common/cmd_jffs2.c          |   20 +++++++++++++++++---
>>  include/jffs2/load_kernel.h |    1 +
>>  2 files changed, 18 insertions(+), 3 deletions(-)
>>
>> diff --git a/common/cmd_jffs2.c b/common/cmd_jffs2.c
>> index 791a572..e2bf198 100644
>> --- a/common/cmd_jffs2.c
>> +++ b/common/cmd_jffs2.c
>> @@ -339,11 +339,15 @@ static int part_validate_nor(struct mtdids *id, struct part_info *part)
>>  	extern flash_info_t flash_info[];
>>  	flash_info_t *flash;
>>  	int offset_aligned;
>> -	u32 end_offset;
>> +	u32 end_offset, sector_size = 0;
>>     
> please spit in two lines
>   
Why do you waste peoples' time with this pedantic nit-picking?  There's 
absolutely nothing wrong with having them both on the same line, 
especially if it's the only thing you can object to in the patch.

regards,
Ben


More information about the U-Boot mailing list