[U-Boot] [PATCH 1/2] bootm: fix BOOTM_STATE_FDT subcommand usage

Wolfgang Denk wd at denx.de
Tue Nov 18 09:55:47 CET 2008


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1226968111-965-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> boot_relocate_fdt can only be used on PPC, M68K and SPARC
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  common/cmd_bootm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index a8f85e9..22e8b30 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -499,6 +499,7 @@ int do_bootm_subcommand (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>  			break;
>  #endif
>  #ifdef CONFIG_OF_LIBFDT
> +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)

This change seems wrong to me. There are PPC systems which do not use
the device tree - why should we enable this code for these?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Living on Earth may be expensive, but it includes an annual free trip
around the Sun.


More information about the U-Boot mailing list