[U-Boot] [PATCH 2/2] fit: Fix little endian target support

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081118093333.GK20874 at game.jcrosoft.org> you wrote:
>
> > Hm.... do you consider this a style cleanup, or is there any real
> > problem that needs fixing?
> on little endian it does not compile

What do you mena - on little endian? I didn't see any build problems
for any of the ARM or le MIPS boards?

> > >  #if __BYTE_ORDER == __LITTLE_ENDIAN
> > > +#ifdef USE_HOSTCC
> > >  #define fdt32_to_cpu(x)		bswap_32(x)
> > >  #define cpu_to_fdt32(x)		bswap_32(x)
> > >  #define fdt64_to_cpu(x)		bswap_64(x)
> > >  #define cpu_to_fdt64(x)		bswap_64(x)
> > >  #else
> > > +#define fdt32_to_cpu(x)		cpu_to_be32(x)
> > > +#define cpu_to_fdt32(x)		cpu_to_be32(x)
> > > +#define fdt64_to_cpu(x)		cpu_to_be64(x)
> > > +#define cpu_to_fdt64(x)		cpu_to_be64(x)
> > > +#endif /* USE_HOSTCC */
> > 
> > This is IMO wrong. If we implement such a change,  then  fdt32_to_cpu
> > should translate to be32_to_cpu, and fdt64_to_cpu should translate to
> > be64_to_cpu.
> > 
> > But actually I do not see the need for this change.
> I've try some arm little endian platfrom without it it does not compile at all

What exactly is the error?

The suggested patch is wrong in any case.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Just because your doctor has a name for your condition  doesn't  mean
he knows what it is.