[U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence

Shinya Kuribayashi skuribay at ruby.dti.ne.jp
Tue Nov 18 16:00:47 CET 2008


Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:18 Wed 12 Nov     , Stefan Roese wrote:
>> diff --git a/lib_mips/board.c b/lib_mips/board.c
>> index 77e1cc8..01dda69 100644
>> --- a/lib_mips/board.c
>> +++ b/lib_mips/board.c
>> @@ -70,6 +70,15 @@ static ulong mem_malloc_brk;
>>   */
>>  unsigned long mips_io_port_base = -1;
>>  
>> +int __board_early_init_f(void)
>> +{
>> +	/*
>> +	 * Nothing to do in this dummy implementation
>> +	 */
>> +	return 0;
>> +}
> why not remove this and create a generic dummy function
> 
> to reduce to code size impact

+1.  Such dummy function could be shared among all architectures.

Thanks,

  Shinya


More information about the U-Boot mailing list