[U-Boot] [PATCH 4/4 V2] add Siemens SX1 Machine support

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1227039511-713-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Siemens SX1 Cellphone V1
>  - ARM OMAP310 processor
>  - SRAM                192 kB
>  - SDRAM                32 MB at 0x10000000
>  - Boot flash           16 MB at 0x00000000
>  - Application flash     8 MB at 0x04000000
>  - 3 serial ports
>  - 1 SecureDigital
>  - 1 LCD display
>  - 1 RTC
> 
> Siemens SX1 Cellphone V2
>  - ARM OMAP310 processor
>  - SRAM                192 kB
>  - SDRAM                32 MB at 0x10000000
>  - Boot flash           32 MB at 0x00000000
>  - 3 serial ports
>  - 1 SecureDigital
>  - 1 LCD display
>  - 1 RTC
> 
> U-Boot (mainline) and Linux kernel (2.6.26) tested
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
> add qemu-doc
> and fix QEMUMachine var name (invert between v1 and v2)
> 
> Best Regards,
> J.
>  Makefile.target      |    2 +-
>  hw/boards.h          |    4 +
>  hw/omap_sx1.c        |  236 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  qemu-doc.texi        |   26 ++++++
>  target-arm/machine.c |    2 +
>  5 files changed, 269 insertions(+), 1 deletions(-)
>  create mode 100644 hw/omap_sx1.c
> 
> diff --git a/Makefile.target b/Makefile.target
> index a15cbe0..03db021 100644
> --- a/Makefile.target
> +++ b/Makefile.target

What's Makefile.target ? There is no such file in mainline.

[And I don't want to have any file by such a name either.]

>  OBJS+= zaurus.o ide.o serial.o nand.o ecc.o spitz.o tosa.o tc6393xb.o
>  OBJS+= omap1.o omap_lcdc.o omap_dma.o omap_clk.o omap_mmc.o omap_i2c.o
>  OBJS+= omap2.o omap_dss.o soc_dma.o
> -OBJS+= palm.o tsc210x.o
> +OBJS+= omap_sx1.o palm.o tsc210x.o
>  OBJS+= nseries.o blizzard.o onenand.o vga.o cbus.o tusb6010.o usb-musb.o
>  OBJS+= tsc2005.o bt-hci-csr.o
>  OBJS+= mst_fpga.o mainstone.o
> diff --git a/hw/boards.h b/hw/boards.h

What's hw/ ?  There is no such firectory in mainline.

> diff --git a/hw/omap_sx1.c b/hw/omap_sx1.c
> new file mode 100644
> index 0000000..e699549
> --- /dev/null
> +++ b/hw/omap_sx1.c

And, as you certainly know, the SX1 is already supported by the code
in board/sx1/ ?



Are you really sure this patch was for the U-Boot mailing list?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lead me not into temptation... I can find it myself.