[U-Boot] [PATCH] Delete unused definitions for SDR0_DDRCFG from ppc4xx.h

Stefan Roese sr at denx.de
Thu Nov 20 19:07:19 CET 2008


On Thursday 20 November 2008, Steven A. Falco wrote:
> The definitions of bits in SDR_CFG are incorrect, and not used within
> U-Boot.  Therefore, they can be removed.
>
> Signed-off-by: Steven A. Falco <sfalco at harris.com>
> ---
>
> As per Stefan's request, here is a patch removing the unused, incorrect
> definitions.
>
> Note that the AMCC DDR spreadsheet does calculate a value for the
> sdr_cfg register, so I am leaving the "#define sdr_cfg 0x00e0" in
> place, to make it easier for boards that have to set this register.

Since the register naming is not really correct (SDR0_DDRCFG instead of 
sdr_cfg on 440EPx) I would really like you to remove this define too. And 
sdr_ddrdl too please. If somebody needs them they can be added quickly and 
with the correct naming please (and upper case this time).

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list