[U-Boot] [PATCH]=?utf-8?q?rtc:=20add=20support=20for=204543=20RTC=20(manufactured=20by=20e.g.=20EPSON)

[Jean-Christophe PLAGNIOL-VILLARD]

> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include <asm/io.h>
> +#include <common.h>
> +#include <command.h>
> +#include <config.h>
> +#include <bcd.h>
> +#include <rtc.h>
> +
> +#if defined(CONFIG_RTC_RTC4543) && defined(CONFIG_CMD_DATE)
please pove this to Makefile
> +
> +int rtc_get(struct rtc_time *tmp)
> +{
> +	int rel = 0;
> +	uchar sec, min, hour, mday, wday, mon, year;
> +
> +	rtc_read(0x00);
> +	sec	= rtc_read(0x01);
> +	min	= rtc_read(0x02);
> +	hour	= rtc_read(0x03);
> +	wday	= rtc_read(0x04);
> +	mday	= rtc_read(0x05);
> +	mon	= rtc_read(0x06);
> +	year	= rtc_read(0x07);
> +	rtc_read(0x08);
> +
> +	debug("Get RTC year: %02x mon/cent: %02x mday: %02x wday: %02x "
> +		"hr: %02x min: %02x sec: %02x\n",
> +		year, mon, mday, wday,
> +		hour, min, sec);
> +
> +	if (sec & 0x80) {
> +		puts("### Warning: RTC Low Voltage - date/time not reliable\n");
> +		rel = -1;
> +	}
> +
> +	tmp->tm_sec  = BCD2BIN(sec  & 0x7F);
                   ^^
please use tab instead of whitespace
> +	tmp->tm_min  = BCD2BIN(min  & 0x7F);
> +	tmp->tm_hour = BCD2BIN(hour & 0x3F);
> +	tmp->tm_mday = BCD2BIN(mday & 0x3F);
> +	tmp->tm_mon  = BCD2BIN(mon & 0x1F);
> +	tmp->tm_year = BCD2BIN(year);
> +	tmp->tm_wday = BCD2BIN(wday & 0x07);
> +	tmp->tm_yday = 0;
> +	tmp->tm_isdst = 0;
> +
> +	debug("Get DATE: %4d-%02d-%02d (wday=%d)  TIME: %2d:%02d:%02d\n",
> +		tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
> +		tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
> +
> +	return rel;
> +}
> +
> +int rtc_set(struct rtc_time *tmp)
> +{
> +	debug("Set DATE: %4d-%02d-%02d (wday=%d)  TIME: %2d:%02d:%02d\n",
> +		tmp->tm_year, tmp->tm_mon, tmp->tm_mday, tmp->tm_wday,
> +		tmp->tm_hour, tmp->tm_min, tmp->tm_sec);
> +
> +	rtc_write(0x00, 0);
> +	rtc_write(0x01, BIN2BCD(tmp->tm_sec));
> +	rtc_write(0x02, BIN2BCD(tmp->tm_min));
> +	rtc_write(0x03, BIN2BCD(tmp->tm_hour));
> +	rtc_write(0x04, BIN2BCD(tmp->tm_wday));
> +	rtc_write(0x05, BIN2BCD(tmp->tm_mday));
> +	rtc_write(0x06, BIN2BCD(tmp->tm_mon));
> +	rtc_write(0x07, BIN2BCD(tmp->tm_year  % 100));
					    ^^
whitespace please fix
> +	rtc_write(0x08, 0);
> +
> +	return 0;
> +}
> +
> +void rtc_reset(void)
> +{
> +  struct rtc_time tmp;
please add an empty line and use tab for indentation
> +  tmp.tm_sec = 0;
> +  tmp.tm_min = 0;
> +  tmp.tm_hour = 0;
> +  tmp.tm_wday = 4;
> +  tmp.tm_mday = 1;
> +  tmp.tm_mon = 1;
> +  tmp.tm_year = 1970;
> +  rtc_set(&tmp);
> +}
> +
> +#endif
> diff --git a/include/rtc.h b/include/rtc.h
> index 785fbe3..019c2eb 100644
> --- a/include/rtc.h
> +++ b/include/rtc.h
> @@ -61,4 +61,8 @@ void to_tm (int, struct rtc_time *);
>  unsigned long mktime (unsigned int, unsigned int, unsigned int,
>  		      unsigned int, unsigned int, unsigned int);
>  
> +uchar rtc_read(uchar reg) __attribute__((weak));
> +void  rtc_write(uchar reg, uchar val) __attribute__((weak));
please private default function

and if you add it please fix the other rtc drivers too

Best Regards,
J.