[U-Boot] [PATCH] inka4x0: hardware diagnosis and RTC.

[Jean-Christophe PLAGNIOL-VILLARD]

On 21:58 Thu 20 Nov     , ap at denx.de wrote:
> From: Andreas Pfefferle <ap at denx.de>
> 
> This patch supports added diagnosis functions and the
diagnosis where?
> use of the external RTC.
>    
> Signed-off-by: Andreas Pfefferle <ap at denx.de>
> ---
>  include/configs/inka4x0.h |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/inka4x0.h b/include/configs/inka4x0.h
> index 405234c..5caa405 100644
> --- a/include/configs/inka4x0.h
> +++ b/include/configs/inka4x0.h
> @@ -97,7 +97,8 @@
>  #define CONFIG_CMD_PCI
>  #define CONFIG_CMD_SNTP
>  #define CONFIG_CMD_USB
> -
> +#define CONFIG_CMD_DATE
> +#define CONFIG_CMD_PING
not mention in the commit message
>  
>  #define	CONFIG_TIMESTAMP	1	/* Print image info with timestamp */
>  
> @@ -241,13 +242,13 @@
>   * use PSC6_1 and PSC6_3 as GPIO: Bits 9:11 (mask: 0x07000000):
>   *	011 -> PSC6 could not be used as UART or CODEC. IrDA still possible.
>   */
> -#define CONFIG_SYS_GPS_PORT_CONFIG	0x01001004
> +#define CONFIG_SYS_GPS_PORT_CONFIG	0x01501444
why do yuo change it?
>  
>  /*
>   * RTC configuration
>   */
> -#define CONFIG_RTC_MPC5200	1	/* use internal MPC5200 RTC */
>  
> +#define CONFIG_RTC_RTC4543 	1	/* use external RTC */
			     ^
whitespace please fix

why not make configurable via if def
as 
ifndef CONFIG_RTC_RTC4543
#define CONFIG_RTC_MPC5200
#endif

Best Regards,
J.